Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader User Profile: Add back button to Lists tab #100962

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Reader User Profile: Add back button to Lists tab #100962

merged 1 commit into from
Mar 7, 2025

Conversation

artemiomorales
Copy link
Contributor

@artemiomorales artemiomorales commented Mar 6, 2025 •
edited
Loading

Related to #100173

Proposed Changes

  • Adds a back button to the lists tab on the user profile page
  • Edits the back button styles so they're under is-section-reader rather than is-reader-page so they affect the Lists too

Why are these changes being made?

Consistency on the user profile pages.

Testing Instructions

  • Visit a user profile page, i.e. /reader/users/artemiosans
  • Click on Lists
  • Ensure the back button appear and works
  • Smoke test the rest of the Reader pages to ensure the back button is still placed correctly

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@artemiomorales artemiomorales added the [Feature] Reader The reader site on Calypso. label Mar 6, 2025
@artemiomorales artemiomorales self-assigned this Mar 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-135627
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-135627&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-135627&env=a8c-for-agencies

@artemiomorales artemiomorales marked this pull request as ready for review March 6, 2025 18:58
@artemiomorales artemiomorales requested a review from a team as a code owner March 6, 2025 18:58
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 6, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
reader        +66 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/user-profile-lists-back-button on your sandbox.

@artemiomorales artemiomorales changed the title Reader: Add back button to Lists page Reader User Profile: Add back button to Lists tab Mar 6, 2025
DustyReagan
DustyReagan approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good!

Addison-Stavlo
Addison-Stavlo approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to give it a test as well since is-section-reader rather than is-reader-page had a few styles past the back button.

Everything looks good from my end too!

@artemiomorales artemiomorales merged commit 6f7f595 into trunk Mar 7, 2025
20 checks passed
@artemiomorales artemiomorales deleted the add/user-profile-lists-back-button branch March 7, 2025 14:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 7, 2025
@artemiomorales artemiomorales linked an issue Mar 7, 2025 that may be closed by this pull request
Reader User Profile: Add Back button to Lists tab #100173
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DustyReagan DustyReagan DustyReagan approved these changes

@Addison-Stavlo Addison-Stavlo Addison-Stavlo approved these changes

Assignees

@artemiomorales artemiomorales

Labels
[Feature] Reader The reader site on Calypso.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reader User Profile: Add Back button to Lists tab
4 participants
@artemiomorales @matticbot @DustyReagan @Addison-Stavlo